Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Support for listing and deleting users in admin section #1288

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

Etsija
Copy link
Contributor

@Etsija Etsija commented Oct 24, 2024

Please have a look at the individual commits for details.

Screenshot from 2024-10-24 18-21-53

Screenshot from 2024-10-24 18-21-29

Screenshot from 2024-10-24 18-22-24

Screenshot from 2024-10-24 18-22-34

Deleting items (organizations, products, repositories, secrets etc.) from
the server can be considered dangerous, as deletion is irreversible and
might have unwanted side effects.

Add an optional boolean prop `textConfirmation` to the delete modal.
When it is set to `true`, the user is required to write the name of the
item which is about to be deleted to an input box, before the Delete 
button is enabled.

Signed-off-by: Jyrki Keisala <[email protected]>
PR #1278 extends user creation by adding optional first name, last name
and email to the user information.

Add these fields to the user creation form and mark them as optional.

Signed-off-by: Jyrki Keisala <[email protected]>
Add support for creating, listing and deleting users. Updating user data
wasn't considered to be necessary at this point, so there's currently no
back-end support for it, thus it is also omitted from the front-end.

List users (username, first name, last name, email) in a data table which
is paginated on client-side. Users can be added and deleted from this
view, and because deleting a user might be considered a dangerous
operation, deleting needs manual text input in the delete dialog.

Signed-off-by: Jyrki Keisala <[email protected]>
@Etsija Etsija requested a review from mmurto as a code owner October 24, 2024 15:27
@Etsija Etsija force-pushed the do-922-ui-support-for-listing-and-deleting-users branch 3 times, most recently from 00b6cb0 to 426a9e3 Compare October 25, 2024 04:17
@Etsija Etsija force-pushed the do-922-ui-support-for-listing-and-deleting-users branch from 426a9e3 to d670ebd Compare October 25, 2024 06:35
@Etsija Etsija enabled auto-merge October 25, 2024 06:47
@Etsija Etsija added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 22cc661 Oct 25, 2024
13 checks passed
@Etsija Etsija deleted the do-922-ui-support-for-listing-and-deleting-users branch October 25, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants